Bump presage and fix receiving direct messages #161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried testing this but the QR is not working, the android app does not recognize it. The QR in the official signal desktop works fine, I just tried it. Can you reproduce this issue? Edit: never mind, I think it was just cache issues, deleting |
|
The fix was done #162. Upgrading presage is a breaking change due to changed format of the presage db. We would need to bump the minor version of gurk, if we merge this as is. Maybe, we could do automatic migration? |
|
I'll send a new PR to bump presage when you're done with your refactoring ⚒️. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct messages sent from another device stopped having the recipient's phone number for quite some time now. We're currently looking at removing
phone_numberfields everywhere in the upstream libraries.That being said, this PR:
presageto da3128b which is built on top of all of the latest Signal protobuf schemas, libsignal v0.17.0 and exposes a way to decrypt group changesJFYI, I think you want to test that a bit more than I did before making a release 🤔