Fix broken data format #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Variants were renamed, and now old json cannot be deserialized anymore.
|
Thanks for that. Just a quick notice: By moving the |
|
Serde allows `other` to be attached only to the last variant. I will redefine the order of it. Thanks for noticing this.
|
|
Okay, makes sense, thanks for the explanation. |
Now we resolve user names from the synced address book, if possible. We fallback to the profile name, if contact is not in the address book. And eventually to contacts phone number, if profile retrieval failed. The contacts are synced on start-up of the app, however max one time per hour. Resolved #140
This reverts commit 049ca91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variants were renamed, and now old json cannot be deserialized
anymore.