chore: Fix feedback on pr

box · Aug 11, 2020 · f54d535 · f54d535
1 parent 2514e39
commit f54d535
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/src/common/types/metadataQueries.js b/src/common/types/metadataQueries.js
@@ -18,7 +18,7 @@ type MetadataQueryOrderByClause = {
 
 type MetadataQuery = {
     ancestor_folder_id: string,
-    fields?: string[],
+    fields?: Array<string>,
     from: string,
     limit?: number,
     marker?: string,

diff --git a/src/features/metadata-based-view/MetadataBasedItemList.js b/src/features/metadata-based-view/MetadataBasedItemList.js
@@ -49,7 +49,7 @@ type State = {
     isUpdating: boolean,
     scrollLeftOffset: number,
     scrollRightOffset: number,
-    valueBeingEdited: ?MetadataFieldValue,
+    valueBeingEdited?: ?MetadataFieldValue,
 };
 
 type Props = {
@@ -97,7 +97,6 @@ class MetadataBasedItemList extends React.Component<Props, State> {
             isUpdating: false,
             scrollLeftOffset: 0,
             scrollRightOffset: 0,
-            valueBeingEdited: undefined,
         };
     };
 

diff --git a/src/features/metadata-based-view/MetadataQueryAPIHelper.js b/src/features/metadata-based-view/MetadataQueryAPIHelper.js
@@ -85,8 +85,7 @@ export default class MetadataQueryAPIHelper {
             delete patchOp.value;
         }
 
-        const ops = operation === JSON_PATCH_OP_ADD ? [patchOp] : [testOp, patchOp];
-        return ops;
+        return operation === JSON_PATCH_OP_ADD ? [patchOp] : [testOp, patchOp];
     };
 
     getMetadataQueryFields = (): string[] => {
@@ -106,7 +105,7 @@ export default class MetadataQueryAPIHelper {
             This function will return ['field_1', 'field_2', 'field_3']
         */
         const { fields = [], from } = this.metadataQuery;
-        return fields.filter(field => field.includes(from)).map(field => field.split(`${from}.`).pop());
+        return fields.filter(field => field.includes(from)).map(field => field.split('.').pop());
     };
 
     flattenMetadata = (metadata?: MetadataType): MetadataType => {