fix(opapi): create a deepcopy of the schema before setting openapi pr…

…operties (#288)
botpress · May 6, 2024 · 8479609 · 8479609
1 parent 30bf1fb
commit 8479609
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/opapi/package.json b/opapi/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bpinternal/opapi",
-  "version": "0.10.14",
+  "version": "0.10.15",
   "description": "",
   "main": "./dist/index.js",
   "module": "./dist/index.mjs",

diff --git a/opapi/src/opapi.ts b/opapi/src/opapi.ts
@@ -13,11 +13,16 @@ import { exportStateAsTypescript, ExportStateAsTypescriptOptions } from './gener
 import { generateHandler } from './handler-generator'
 export { Operation, Parameter } from './state'
 
-type ExtendApi = typeof extendApi
-type AnatineSchemaObject = NonNullable<Parameters<ExtendApi>[1]>
+type AnatineSchemaObject = NonNullable<Parameters<typeof extendApi>[1]>
 
-export const schema: <T extends OpenApiZodAny>(schema: T, schemaObject?: AnatineSchemaObject & { $ref?: string }) => T =
-  extendApi
+export const schema = <T extends OpenApiZodAny>(
+  schema: T,
+  schemaObject?: AnatineSchemaObject & { $ref?: string },
+): T => {
+  const This = (schema as any).constructor
+  const copy = new This(schema._def) as T
+  return extendApi(copy, schemaObject)
+}
 
 export type OpenApi<
   SchemaName extends string = string,

diff --git a/opapi/src/state.ts b/opapi/src/state.ts
@@ -269,7 +269,7 @@ export function createState<SchemaName extends string, DefaultParameterName exte
     }
 
     if (schemas[name]) {
-      throw new VError(`Operation ${name} already exists`)
+      throw new VError(`Schema ${name} already exists`)
     }
 
     schemas[name] = {