automod: recover from panics in applying effects #1695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of several aiming to mitigate the impact of bugs similar to those introduced in the previous release.
The most pressing issue was the inadvertent removal of a nil guard in
KickUser
by me in #1659, which caused panics which were difficult to track down. To make these easier to debug in future (and to prevent complete bot crashes), in this PR we recover and log a stacktrace for panics in applying advanced automod effects and basic automod punishments. This supercedes the temporary bandaid recover added directly toKickUser
in f9602a1.For reference, I compiled a version of the bot with the nil pointer bug re-added (but with this patch applied as well.) Instead of crashing, the following is logged instead:
which points directly to the problematic line.