Move the base64 & sha256 functions to general.go and change name of sha256 function to hash #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Borbot33
changed the title
|
From my UI, your last commit does not contribute to the overall diff: that is, this PR does not seem to delete the context functions you added. Is that a visual issue on my side, or is it the case for you as well (check the "Files changed" tab?) If the latter, try rebasing on current dev; I suspect your base branch is outdated. |
jo3-l
reviewed
Jun 22, 2024
common/templates/general.go
Outdated
Comment on lines
1706
to
1709
| hash := sha256.New() | ||
| hash.Write([]byte(str)) | ||
|
|
||
| sha256 := base64.URLEncoding.EncodeToString(hash.Sum(nil)) |
There was a problem hiding this comment.
You may also want to run this change by gofmt: these lines are indented with spaces instead of tabs like the rest of the code.
Borbot33
force-pushed
the
base64-and-sha256
branch
from
34ae9b9
to
6559042
Compare
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…ha256 function to hash (botlabs-gg#1682) * moved functions from context_funcs.go to general.go * changed function name from sha256 to hash * moved functions from context_funcs.go to general.go * added a tab
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…ha256 function to hash (botlabs-gg#1682) * moved functions from context_funcs.go to general.go * changed function name from sha256 to hash * moved functions from context_funcs.go to general.go * added a tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.