poll,wyr: obey response autodeletion set via command overrides #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...designed for commands that send their responses manually as opposed to through dcmd, such as the poll command.
This commit (combined with the previous) allows poll and wyr responses to be autodeleted after a delay via command overrides. Previously, the command system had no knowledge of responses to these commands (which are sent manually since reactions need to be added), so autodeletion did not work.
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 20, 2024
…bs-gg#1672) * dcmd: add manual response marker ...designed for commands that send their responses manually as opposed to through dcmd, such as the poll command. * poll,wyr: indicate to dcmd that responses are sent manually This commit (combined with the previous) allows poll and wyr responses to be autodeleted after a delay via command overrides. Previously, the command system had no knowledge of responses to these commands (which are sent manually since reactions need to be added), so autodeletion did not work.
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…bs-gg#1672) * dcmd: add manual response marker ...designed for commands that send their responses manually as opposed to through dcmd, such as the poll command. * poll,wyr: indicate to dcmd that responses are sent manually This commit (combined with the previous) allows poll and wyr responses to be autodeleted after a delay via command overrides. Previously, the command system had no knowledge of responses to these commands (which are sent manually since reactions need to be added), so autodeletion did not work.
ashishjh-bst
pushed a commit
to ashishjh-bst/yagpdb
that referenced
this pull request
Jun 27, 2024
…bs-gg#1672) * dcmd: add manual response marker ...designed for commands that send their responses manually as opposed to through dcmd, such as the poll command. * poll,wyr: indicate to dcmd that responses are sent manually This commit (combined with the previous) allows poll and wyr responses to be autodeleted after a delay via command overrides. Previously, the command system had no knowledge of responses to these commands (which are sent manually since reactions need to be added), so autodeletion did not work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1671. This PR allows poll and wyr responses to be autodeleted after a delay via command overrides. Previously, the command system had no knowledge of responses to these commands (which are sent manually since reactions need to be added), so autodeletion did not work.