Merge pull request #399 from boozook/upd-fix-panic

Fix panic, update toolchain & deps
boozook · Jul 13, 2024 · ea28ed4 · ea28ed4
2 parents cd45239 + 6529a84
commit ea28ed4
Show file tree

Hide file tree

Showing 35 changed files with 314 additions and 324 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -475,31 +475,11 @@ jobs:
 
       - name: Check
         id: check
-        continue-on-error: true
-        run: >-
-          cargo fmt --all -- --check ||
-          (echo "::error::Rust format error." && exit 1)
-
-      - name: Format
-        id: format
-        if: steps.check.outcome == 'failure'
-        run: cargo fmt --all
-
-      - name: Suggestions
-        uses: reviewdog/action-suggester@v1
-        with:
-          filter_mode: diff_context
-          fail_on_error: false
-          tool_name: Rustfmt
-          cleanup: false
-
-      - name: Post Check
-        if: steps.check.outcome == 'failure'
-        run: exit 1
+        run: cargo fmt --all -- --check
 
   clippy:
-    name: Clippy
-    if: github.event_name == 'pull_request'
+    name: Clippy + fmt suggestions
+    if: github.event_name == 'pull_request' || github.event_name == 'pull_request_target'
     defaults:
       run:
         shell: bash
@@ -521,7 +501,6 @@ jobs:
       - uses: actions/checkout@v4
         with:
           ref: ${{ inputs.ref || github.ref }}
-          # fetch-depth: 2
 
       - name: Install Clippy
         run: rustup component add clippy
@@ -557,7 +536,6 @@ jobs:
           -p=playdate-tool
           --bins --examples --all-targets
           -- -Aclippy::cargo
-          || (echo "::error::Rust format error." && exit 1)
 
       # needed after clippy fix
       - name: fmt
@@ -572,6 +550,6 @@ jobs:
         with:
           filter_mode: diff_context
           fail_on_error: false
-          tool_name: Clippy
+          tool_name: Clippy & fmt
           cleanup: false