Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/value to hides exceptions #913

Merged
merged 5 commits into from
Jul 5, 2023
Merged

Fix/value to hides exceptions #913

merged 5 commits into from
Jul 5, 2023

Conversation

grisumbras
Copy link
Member

Fix #903

@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/913/pullrequest.html

@grisumbras grisumbras force-pushed the fix/value_to-hides-exceptions branch from 34ced2a to 9de79e0 Compare June 29, 2023 14:55
@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/913/pullrequest.html

@grisumbras grisumbras force-pushed the fix/value_to-hides-exceptions branch 2 times, most recently from 287b70f to 3c2e701 Compare June 29, 2023 16:41
@grisumbras grisumbras force-pushed the fix/value_to-hides-exceptions branch from 3c2e701 to 0a7860f Compare July 3, 2023 14:59
@cppalliance-bot
Copy link

An automated preview of the documentation is available at https://913.jsondocs.prtest.cppalliance.org/libs/json/doc/html/index.html

@codecov
Copy link

codecov bot commented Jul 3, 2023 •
edited
Loading

Codecov Report

Merging #913 (0a7860f) into develop (00ba384) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #913      +/-   ##
===========================================
- Coverage    92.97%   92.95%   -0.03%     
===========================================
  Files           85       85              
  Lines         8072     8047      -25     
===========================================
- Hits          7505     7480      -25     
  Misses         567      567
Impacted Files Coverage Δ
include/boost/json/impl/conversion.hpp 100.00% <ø> (ø)
include/boost/json/detail/value_to.hpp 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ba384...0a7860f. Read the comment docs.

@grisumbras grisumbras mentioned this pull request Jul 3, 2023
Closed
@grisumbras grisumbras marked this pull request as ready for review July 3, 2023 15:39
@cppalliance-bot
Copy link

pullrequest
Benchmark test results. More info at https://benchmark.cppalliance.org/jsonbenchmarks-pullrequests/913/pullrequest.html

@grisumbras grisumbras merged commit 0a7860f into boostorg:develop Jul 5, 2023
3 of 4 checks passed
@grisumbras grisumbras deleted the fix/value_to-hides-exceptions branch July 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception in custom tag_invoke(value_to_tag)
2 participants
@grisumbras @cppalliance-bot