Refactoring graphviz_test for review #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works around invalidation of bundle property maps (see boostorg#373). The `#if SEHE_UNSTABLE_PROPERTY_MAPS_FIXED` section is there to signal my intent to investigate a generalized fix under that issue. It doubles as literate documentation of the need for the workaround, so it's less likely to bite the unwary.
This was referenced May 3, 2024
The code was mostly fine (except for unhygienic `using namespace` in places), but it was hard to see what was covered. I've seperated fixtures (sample input + expected output) and this will simplify invoking the ComparisonDriver (test_graph).
sehe
force-pushed
the
graphviz_test-refactor
branch
from
98bed5e
to
8126d97
Compare
|
Updated for review comments #364 (comment) |
Comment on lines
+30
to
+31
| typedef std::map< node_t, Mass > expected_masses_t; | ||
| typedef std::map< edge_t, Weight > expected_weights_t; |
There was a problem hiding this comment.
Personally, I think the type names should be more like node_mass_map_t, edge_weight_map_t and the variables should be named expected_mass, etc, but I'm not going to hold up the review over it. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note this PR builds on #374)
The code was mostly fine (except for unhygienic
using namespaceinplaces), but it was hard to see what was covered.
I've seperated fixtures (sample input + expected output), and models into separate namespaces.
This simplifies invocations of the ComparisonDriver (test_graph).