Add missing includes to graph headers #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some graph .hpp files are using APIs without including the associated headers. This can cause compile errors if these headers are included first in a .cpp file.
|
This likely isn't a huge deal in practice. We do carry this patch locally, as our workflow verifies that header files build standalone, so I figured it was worth asking if upstream is interested in it. |
|
Always interested in patches that improve the quality of basically using the library! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some graph .hpp files are using APIs without including the associated headers. This can cause compile errors if these headers are included first in a .cpp file.