Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to upnpclient from upnpy #244

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

brostosjoined
Copy link
Member

@brostosjoined brostosjoined commented Mar 18, 2024

Some gamers raised concerns about no upnp device found error while upnp was enabled so i switched to this more recent library.

OS Tester x86_64 aarch64/ arm64
Windows 💻 brostos ✔️
MacOS Doffy $${\color{red}PermissionError}$$ Untested
Linux 3ra0S ✔️ Untested
Android Untested Untested Untested

The PermissionError occurs while trying to download and copy the modules to a directory that doesnt have the permissions tried changing it with python os module but still same outcome.

@brostosjoined brostosjoined marked this pull request as draft March 18, 2024 20:50
@brostosjoined
Copy link
Member Author

I need testers

@brostosjoined brostosjoined added wontfix This will not be worked on bug Something isn't working plugin Everything plugin labels Apr 15, 2024
@brostosjoined brostosjoined added wontfix This will not be worked on and removed wontfix This will not be worked on labels Apr 22, 2024
brostosjoined and others added 11 commits April 30, 2024 16:10
```python
# ba_meta require api 8
import bascenev1 as bs
import babase
import threading
import time


def threaded(func):
    def wrapper(*args, **kwargs):
        thread = threading.Thread(
            target=func, args=args, kwargs=kwargs, name=func.__name__
        )
        thread.start()
    return wrapper


def play_sound():
    with bs.get_foreground_host_activity().context:
        bs.getsound('gunCocking').play()
        bs.getsound('cashRegister').play()
        bs.getsound('error').play()
        bs.getsound('shieldDown').play()
        bs.getsound('swish').play()


@threaded
def player():
    time.sleep(2)
    babase.pushcall(play_sound, from_other_thread=True)


# ba_meta export babase.Plugin
class EntryPoint(babase.Plugin):
    def on_app_running(self):
        player()
```

fixes `RuntimeError : Sound creation failed`
 - Android Doesnt work with natpmp
 - Efro broke windows rich presence on .35 again
@brostosjoined

This comment was marked as outdated.

@brostosjoined
Copy link
Member Author

brostosjoined commented Aug 30, 2024

A bug on discordrp that says am online when am connected to the same device on the same laptop maybe even on same network. Perform some checks to find out if the public ip address are the same or something equivalent and faster

@brostosjoined
Copy link
Member Author

Android uses Bionic libc as its C library, a streamlined version tailored for mobile devices, different from glibc. So perfom a check on the device to see if its mobile then do some patching to platform.platform() i think this function doesnt work on a mac.

@brostosjoined brostosjoined removed the wontfix This will not be worked on label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin Everything plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants