Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define callback refs inline to work with latest versions of Next.js / React #819

Merged
merged 1 commit into from
May 26, 2024

Conversation

jmurty
Copy link
Contributor

@jmurty jmurty commented May 24, 2024

Callback refs defined as class functions don't get invoked in Next.js 14.2+ – and therefore don't work – perhaps because of changes to the underlying React which is at or near version 19.

This should fix bokuweb/react-rnd#941 along with the related PR on react-rnd: bokuweb/react-rnd#942

Tested and confirmed to work with the latest stable version of Next.js 14.2.3

… React

Callback refs defined as class functions don't get invoked in
Next.js 14.2+ – and therefore don't work – perhaps because of changes
to the underlying React which is at or near version 19.
Copy link
Owner

@bokuweb bokuweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bokuweb bokuweb merged commit 57d116f into bokuweb:master May 26, 2024
3 checks passed
@bokuweb
Copy link
Owner

bokuweb commented May 26, 2024

@jmurty Thanks. 6.9.17 published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: <DraggableCore> not mounted on DragStart! when trying to use in NextJS
2 participants