Add false to ResizableProps.enable #789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution
In current behavior, all resizers are disabled if we pass
false
toResizableProps.enable
.re-resizable/src/index.tsx
Lines 888 to 890 in da458ab
However current type definition does not accept
false
so I fixed the type.Tradeoffs
N/A
Testing Done
Tested with passing
false
to actual Resizable component.