chore: add the wrapper layer of versa #2636
Conversation
joeylichang
force-pushed
the
versa_interface
branch
from
f896f80
to
41ab497
Compare
|
|
||
| type cachingVersaDB struct { | ||
| triedb *triedb.Database | ||
| versionDB versa.Database |
There was a problem hiding this comment.
Why to have a "versionDB" here? Is there any difference with "triedb"?
There was a problem hiding this comment.
There is no essential difference; here, versiondb is for convenience.
| codeSizeCache *lru.Cache[common.Hash, int] | ||
| codeCache *lru.SizeConstrainedCache[common.Hash, []byte] | ||
|
|
||
| accTree *VersaTree |
There was a problem hiding this comment.
Where is VersaTree impl? And why to have a "accTree"?
There was a problem hiding this comment.
Facilitate OpenStorageTree to avoid reopen.
core/state/caching_versa_db.go
Outdated
| } | ||
|
|
||
| // TODO:: if root tree, versa db shouldb ignore check version | ||
| state, err := cv.versionDB.OpenState(0, root, cv.mode) |
There was a problem hiding this comment.
Suggest to use the block num as the version here, not 0.
There was a problem hiding this comment.
It’s fine, but currently, this version is of no use to the upper layer and has brought about a burden. The plan is to make the upper layer aware of the version only if needed in the future. The conclusion is that it can be transparent to the upper layer for the time being.
| return val | ||
| } | ||
|
|
||
| func (vt *VersaTree) GetAccount(address common.Address) (*types.StateAccount, error) { |
There was a problem hiding this comment.
I think the version of the account should be returned to the caller, and maintained by the account itself, so that it can be provided to versaDB when opening the storage tree.
But if do this, a lot of changes will be required. Therefore, we need to do some trade off whether the version should be known to the caller.
There was a problem hiding this comment.
Similarly, currently the upper layer does not have a strong dependency on the version, so it can be transparent to the upper layer for the time being. If needed in the future, it can be exposed then. The focus at this stage should not be on this.
joeylichang
force-pushed
the
versa_interface
branch
from
261e67f
to
e1a2b8e
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
a8cf691
to
78da6b6
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
78da6b6
to
bb167a9
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
0802a8c
to
60df2fa
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
11f9fa8
to
6188aae
Compare
joeylichang
force-pushed
the
versa_base
branch
from
b48c5d1
to
5153e69
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
5d0eec2
to
d162a63
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
8834138
to
1cbdf0a
Compare
joeylichang
force-pushed
the
versa_interface
branch
from
1a70548
to
36044b0
Compare
joeylichang
force-pushed
the
versa_base
branch
from
ccd9ce0
to
83a9b13
Compare
Description
add a description of your changes here...
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: