Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more commitment parameters #89

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

tiago18c
Copy link
Member

Status Type ⚠️ Core Change Issue
Ready Feature/Bug Yes Closes #88

Problem

What problem are you trying to solve?
Missing and mishandled commitment parameters.

Solution

How did you solve the problem?
Added more commitment parameters to the getBlockHeight, getBlockProduction and getBlocks methods.
Fixed getBlock not handling commitment properly.
Simplified GetBlockProduction overloads

…ction and getBlocks methods.

Fixed getBlock not handling commitment properly.
Simplified GetBlockProduction overloads
@tiago18c tiago18c requested a review from hoakbuilds June 12, 2021 15:47
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiago18c tiago18c merged commit 8d23809 into bmresearch:master Jun 12, 2021
@tiago18c tiago18c deleted the 88-added-more-commitment branch December 10, 2021 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Added some commitment parameters, fixed bug
2 participants