Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements all Slot related methods and fixing some docs #54

Merged
merged 1 commit into from
Jun 5, 2021
Merged

Implements all Slot related methods and fixing some docs #54

merged 1 commit into from
Jun 5, 2021

Conversation

hoakbuilds
Copy link
Member

@hoakbuilds hoakbuilds commented Jun 4, 2021 •
edited
Loading

Status Type ⚠️ Core Change Issue
Ready Feature/Bug/Refactor/ No #31 Closes #53

Problem

What problem are you trying to solve?

getMinimumBalanceForRentExemption is untested
no implementation for the following Slot-related methods

  • getSlot
  • getSlotLeaders
  • getSlotLeader
  • getSnapshotSlot
  • getMaxRetransmitSlot
  • getMaxShredInsertSlot

as well as getLargestAccounts

Solution

How did you solve the problem?

Added test for getMinimumBalanceForRentExemption
Implemented the Slot methods and while fixing docs also added the LargestAccounts method in order to solve naming convention conflict with the new LargeTokenAccounts

@hoakbuilds hoakbuilds requested a review from tiago18c June 4, 2021 20:49
tiago18c
tiago18c reviewed Jun 5, 2021
View reviewed changes
Copy link
Member

@tiago18c tiago18c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about that empty Transaction class. If you delete it consider this approved.

src/Solnet.Rpc/Models/Transaction.cs Outdated Show resolved Hide resolved
@hoakbuilds hoakbuilds merged commit 1a8d40b into bmresearch:master Jun 5, 2021
@hoakbuilds hoakbuilds deleted the 53-implement-get-slot-methods branch June 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiago18c tiago18c tiago18c left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Slot related rpc methods
2 participants
@hoakbuilds @tiago18c