Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implements getVersion #49

Merged
merged 3 commits into from
Jun 3, 2021
Merged

Implements getVersion #49

merged 3 commits into from
Jun 3, 2021

Conversation

hoakbuilds
Copy link
Member

Status Type ⚠️ Core Change Issue
Ready / Wait for #46 Feature No #31 Closes #48

Problem

What problem are you trying to solve?

No getVersion rpc method implementation

Solution

How did you solve the problem?

Implemented getVersion rpc method

@hoakbuilds hoakbuilds requested a review from tiago18c June 3, 2021 21:24
tiago18c
tiago18c approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@tiago18c tiago18c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hoakbuilds hoakbuilds changed the title Implemens getVersion Implements getVersion Jun 3, 2021
@hoakbuilds hoakbuilds merged commit c694e33 into bmresearch:master Jun 3, 2021
@hoakbuilds hoakbuilds deleted the 48-implement-get-version branch June 5, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiago18c tiago18c tiago18c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement getVersion
2 participants
@hoakbuilds @tiago18c