Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging to streaming client. Improved logging experience in deb… #42

Merged
merged 3 commits into from
Jun 3, 2021

Conversation

tiago18c
Copy link
Member

@tiago18c tiago18c commented Jun 3, 2021

Status Type ⚠️ Core Change Issue
Ready Feature Yes/No #29 + Closes #27

Problem

What problem are you trying to solve?
Improving the library by adding better logging and debug experience.

Solution

How did you solve the problem?
Added logging to streaming client. Added default console logger for debugging.

@tiago18c tiago18c requested a review from hoakbuilds June 3, 2021 12:52
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking very good 👌

@tiago18c tiago18c merged commit 2d770f0 into bmresearch:master Jun 3, 2021
@tiago18c tiago18c deleted the 27-improving-logging branch February 19, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logger to clients and implement client factory with client interfaces
2 participants