Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed account data #23

Merged
merged 8 commits into from
May 31, 2021
Merged

Fixed account data #23

merged 8 commits into from
May 31, 2021

Conversation

tiago18c
Copy link
Member

Status Type ⚠️ Core Change Issue
Ready Bug & Refactor Yes Closes #20

Problem

What problem are you trying to solve?
Account info method and subscription would cause exceptions in the json parsin.

Solution

How did you solve the problem?
Its impossible to know what the object we're parsing during the getAccountInfo method, so the idea is to return the base64 encoded data and let the user figure out what to do with it.

@tiago18c tiago18c requested a review from hoakbuilds May 31, 2021 22:03
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiago18c tiago18c merged commit 5037de6 into bmresearch:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify AccountInfo
2 participants