Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QoL changes #134

Merged
merged 1 commit into from
Jun 30, 2021
Merged

QoL changes #134

merged 1 commit into from
Jun 30, 2021

Conversation

tiago18c
Copy link
Member

@tiago18c tiago18c commented Jun 30, 2021

Status Type ⚠️ Core Change Issue
Ready Refactor No Closes #133

Problem

Perf and testing issues.

Solution

Added performance to Key constructors (lazy initialization of Encoded/decoded values)

Changed visibility and added default constructor

…/decoded values)

Changed visibility and added default construt
@tiago18c tiago18c requested a review from hoakbuilds June 30, 2021 20:19
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiago18c tiago18c merged commit b6a90f9 into bmresearch:master Jun 30, 2021
@tiago18c tiago18c deleted the 133-qol-changes branch February 19, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QoL changes
2 participants