Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed TransactionError parsing in log notifications #123

Merged
merged 2 commits into from
Jun 25, 2021
Merged

Fixed TransactionError parsing in log notifications #123

merged 2 commits into from
Jun 25, 2021

Conversation

tiago18c
Copy link
Member

Status Type ⚠️ Core Change Issue
Ready Bug No Closes #122

Problem

Issue parsing transaction errors in log notifications.

Solution

Changed the type of the 'err' to the expected TransactionError.

@tiago18c tiago18c requested a review from hoakbuilds June 25, 2021 17:41
hoakbuilds
hoakbuilds approved these changes Jun 25, 2021
View reviewed changes
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiago18c tiago18c merged commit 28d59fd into bmresearch:master Jun 25, 2021
@tiago18c tiago18c deleted the 122-fixed-transaction-error-parsing branch February 19, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoakbuilds hoakbuilds hoakbuilds approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Parsing log notifications with transaction errors
2 participants
@tiago18c @hoakbuilds