support BootProgress on SMC X12/X13 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Read through the changes, this lgtm. I'll have to add those functions to x13.go after I rebase on top of this. |
DoctorVin
changed the title
joelrebel
reviewed
Oct 3, 2024
joelrebel
reviewed
Oct 3, 2024
joelrebel
reviewed
Oct 3, 2024
|
I think I've addressed all requests as of the latest commit. |
coffeefreak101
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Add support for using redfish to retrieve the BootProgress from X12/X13 model servers. One of my concerns is that the version of the BMC software determines the redfish version, which can complicate the operational side of things.
This is a draft to get some consensus around my approach so far.
Checklist
The HW vendor this change applies to (if applicable)
SMC
The HW model number, product name this change applies to (if applicable)
X12 (so far)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes