Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TerminateSOL method #381

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

zevweiss
Copy link
Contributor

@zevweiss zevweiss commented Dec 13, 2023

What does this PR implement/change/remove?

A new operation to terminate an active SOL session.

Checklist

  • Tests added
  • Similar commits squashed

Description for changelog/release notes

A new `TerminateSOL` operation, via the ipmitool provider, can be used to terminate an active SOL session.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (6487b60) 43.47% compared to head (288790d) 43.73%.

Files Patch % Lines
client.go 0.00% 6 Missing ⚠️
bmc/sol.go 94.11% 1 Missing and 1 partial ⚠️
providers/ipmitool/ipmitool.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   43.47%   43.73%   +0.25%     
==========================================
  Files          59       60       +1     
  Lines        5274     5316      +42     
==========================================
+ Hits         2293     2325      +32     
- Misses       2762     2771       +9     
- Partials      219      220       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature, left some feedback on the naming of this method.

client.go Outdated Show resolved Hide resolved
bmc/sol.go Outdated Show resolved Hide resolved
@zevweiss zevweiss force-pushed the terminate-sol branch 2 times, most recently from e8689e8 to 0149a9e Compare December 22, 2023 01:14
@zevweiss zevweiss marked this pull request as ready for review December 22, 2023 01:15
This method will terminate an SOL (serial-over-lan) session currently
active on the BMC (if there is one).  The only provider implementing it
is ipmitool, via 'ipmitool sol deactivate'.
@zevweiss zevweiss merged commit e23dfc5 into bmc-toolbox:main Jan 8, 2024
5 checks passed
@zevweiss zevweiss deleted the terminate-sol branch January 8, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants