Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetBootDeviceOverride support for redfish #367

Merged
merged 6 commits into from
Nov 22, 2023

Conversation

coffeefreak101
Copy link
Collaborator

What does this PR implement/change/remove?

Adds a method to the client for getting boot device override settings.

The information returned includes:

  • If the override is persistent
  • If the override mode is UEFI
  • The override device

The output was designed to be similar to the parameters of the BootDeviceSet method.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

Redfish APIs

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (6c585e6) 44.40% compared to head (b145fcb) 44.60%.
Report is 1 commits behind head on main.

Files Patch % Lines
internal/redfishwrapper/boot_device.go 0.00% 33 Missing ⚠️
client.go 0.00% 6 Missing ⚠️
providers/redfish/redfish.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #367      +/-   ##
==========================================
+ Coverage   44.40%   44.60%   +0.20%     
==========================================
  Files          61       61              
  Lines        5155     5201      +46     
==========================================
+ Hits         2289     2320      +31     
- Misses       2610     2625      +15     
  Partials      256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmc/boot_device.go Outdated Show resolved Hide resolved
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, apart from a few suggestions - it looks good.

bmc/boot_device.go Outdated Show resolved Hide resolved
bmc/boot_device.go Outdated Show resolved Hide resolved
bmc/boot_device.go Outdated Show resolved Hide resolved
errors/errors.go Outdated Show resolved Hide resolved
internal/redfishwrapper/boot_device.go Outdated Show resolved Hide resolved
client.go Show resolved Hide resolved
joelrebel
joelrebel previously approved these changes Nov 21, 2023
@coffeefreak101 coffeefreak101 merged commit 834c495 into main Nov 22, 2023
7 checks passed
@coffeefreak101 coffeefreak101 deleted the add-method-getbootdeviceoverride branch November 22, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants