Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e3c256d4i support #357

Merged
merged 3 commits into from
Oct 30, 2023
Merged

e3c256d4i support #357

merged 3 commits into from
Oct 30, 2023

Conversation

ofaurax
Copy link
Collaborator

@ofaurax ofaurax commented Oct 25, 2023

By default, update is broken on e3c256d4i. This PR fixes it. Compatibility with e3c246d4i needs to be tested

@ofaurax ofaurax marked this pull request as draft October 25, 2023 18:17
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (153e11d) 45.05% compared to head (e63714c) 45.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
+ Coverage   45.05%   45.08%   +0.02%     
==========================================
  Files          54       54              
  Lines        4208     4228      +20     
==========================================
+ Hits         1896     1906      +10     
- Misses       2104     2110       +6     
- Partials      208      212       +4     
Files Coverage Δ
providers/asrockrack/helpers.go 49.44% <63.63%> (+0.40%) ⬆️
providers/asrockrack/firmware.go 12.71% <50.00%> (+2.52%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ofaurax ofaurax marked this pull request as ready for review October 26, 2023 14:55
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this submission, can we also make sure this does not cause a regression on the older e3c246d4i

providers/asrockrack/firmware.go Outdated Show resolved Hide resolved
providers/asrockrack/firmware.go Outdated Show resolved Hide resolved
providers/asrockrack/helpers.go Outdated Show resolved Hide resolved
@ofaurax ofaurax changed the title Fs-989 e3c256d4i support e3c256d4i support Oct 27, 2023
providers/asrockrack/firmware.go Outdated Show resolved Hide resolved
providers/asrockrack/firmware.go Outdated Show resolved Hide resolved
providers/asrockrack/helpers.go Outdated Show resolved Hide resolved
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@ofaurax ofaurax merged commit 25d7063 into main Oct 30, 2023
7 checks passed
@ofaurax ofaurax deleted the fs-989-e3c256d4i-support branch October 30, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants