Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SEL Clear Support #349

Merged
merged 11 commits into from
Sep 23, 2023
Merged

Add SEL Clear Support #349

merged 11 commits into from
Sep 23, 2023

Conversation

mattcburns
Copy link
Contributor

What does this PR implement/change/remove?

Adds the ability to clear the SEL on the target BMC via IPMI and Redfish.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

N/A

The HW model number, product name this change applies to (if applicable)

N/A

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

N/A

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

N/A

Description for changelog/release notes

Added ability to clear the SEL via either IPMI or Redfish.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage: 50.87% and project coverage change: +0.08% 🎉

Comparison is base (426d0de) 44.65% compared to head (8712fb6) 44.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   44.65%   44.74%   +0.08%     
==========================================
  Files          51       54       +3     
  Lines        4116     4173      +57     
==========================================
+ Hits         1838     1867      +29     
- Misses       2069     2096      +27     
- Partials      209      210       +1     
Files Changed Coverage Δ
client.go 54.50% <0.00%> (-1.06%) ⬇️
internal/redfishwrapper/sel.go 0.00% <0.00%> (ø)
providers/ipmitool/ipmitool.go 0.00% <0.00%> (ø)
providers/redfish/redfish.go 25.53% <ø> (ø)
providers/redfish/sel.go 0.00% <0.00%> (ø)
bmc/sel.go 85.29% <85.29%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean implementation here, apart from the abbreviation changes it looks good to me

examples/sel/main.go Outdated Show resolved Hide resolved
providers/providers.go Outdated Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
@joelrebel
Copy link
Member

@mattcburns this requires another rebase on main, then set the ready-to-merge label when ready

@mattcburns
Copy link
Contributor Author

@joelrebel Looks like I don't have permissions to add labels to this PR but I did update to main.

@mergify mergify bot merged commit ba1367e into bmc-toolbox:main Sep 23, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants