Redfish stream multipart uploads #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes were already part of bmclib v1 but missed out from being included in v2, #279
2 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 42.67% 42.68%
=======================================
Files 44 44
Lines 3691 3730 +39
=======================================
+ Hits 1575 1592 +17
- Misses 1937 1951 +14
- Partials 179 187 +8
☔ View full report in Codecov by Sentry. |
mattcburns
approved these changes
Aug 23, 2023
mmlb
reviewed
Aug 23, 2023
providers/redfish/firmware.go
Outdated
|
|
||
| size = finfo.Size() | ||
|
|
||
| } else { |
There was a problem hiding this comment.
Any clue what other kinds of readers might show up here? It might be nice to see if the implementation of reader might have a .Len method so we can avoid unnecessary reads.
type Lenner interface {
Len() int
}
...
if file, ok := reader.(*os.File); ok {
...
} else if lenner, ok := reader.(Lenner); ok {
...
} else {
// read the file to get size
}There was a problem hiding this comment.
Hmm, this might need some rethinking - since we also require the file name here,
if file, ok := reader.(*os.File); ok {
// Add update file fields
if _, err = form.CreateFormFile(key, filepath.Base(file.Name())); err != nil {
return 0, body, err
}
...
}
mmlb
reviewed
Aug 25, 2023
|
@mmlb whenever you're back, PTAL :) |
…t instead This makes the code easier to read and maintain. As of now we limit the method to expect an os.File as an io.Reader, once its clear theres other implementations of io.Readers required we can accept those and figure how to determine the file size for the multipart payload
mmlb
reviewed
Sep 6, 2023
This makes the UpdateParameters handling easier to grok and maintain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
The Redfish provider currently reads the firmware files into memory before a multipart upload,
this results in high memory consumption for the client and can be problematic for cases
where firmware installs have to be performed simultaneously.
This change was part of bmclib v1 #279
but was somehow missed from being included in v2.
Tested with Dell R6515's, R7640.
heap profile - with streaming uploads
heap profile - without streaming uploads
Checklist
Description for changelog/release notes