Redfish override timeout for FirmwareInstall #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelrebel
changed the title
joelrebel
added a commit
to metal-toolbox/flasher
that referenced
this pull request
Jul 11, 2023
This fixes the issue where the FirmwareInstall step on BMCs with Redfish have too little time to complete because of the way the Gofish Redfish driver used in bmclib sets timeouts. related bmc-toolbox/bmclib#337
DoctorVin
reviewed
Jul 11, 2023
| // this gives the BMC enough time to have the firmware uploaded and return a response to the client. | ||
| ctxDeadline, _ := ctx.Deadline() | ||
| if time.Until(ctxDeadline) < 10*time.Minute { | ||
| return "", errors.Wrap(errInsufficientCtxTimeout, " "+time.Until(ctxDeadline).String()) |
There was a problem hiding this comment.
What's the operational impact of this error? Is this something we expect to have retried? Would we expect a retry to work? Does an exit here leave the BMC in a sane state?
There was a problem hiding this comment.
As in with all bmclib functions, its upto the caller to retry with a higher timeout value and/or to close the bmc connection. We provide examples for invoking these methods - https://github.com/bmc-toolbox/bmclib/blob/main/examples/install-firmware/main.go
joelrebel
added a commit
to metal-toolbox/flasher
that referenced
this pull request
Jul 12, 2023
This fixes the issue where the FirmwareInstall step on BMCs with Redfish have too little time to complete because of the way the Gofish Redfish driver used in bmclib sets timeouts. related bmc-toolbox/bmclib#337
DoctorVin
approved these changes
Jul 13, 2023
joelrebel
force-pushed
the
redfish-override-timeout
branch
from
cbbab46
to
725e651
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
==========================================
+ Coverage 42.59% 42.67% +0.07%
==========================================
Files 44 44
Lines 3679 3691 +12
==========================================
+ Hits 1567 1575 +8
- Misses 1933 1937 +4
Partials 179 179
☔ View full report in Codecov by Sentry. |
DoctorVin
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
FirmwareInstallmethod.FirmwareInstallmethod.The Redfish wrapper client - Gofish has a context timeout on the HTTP client set when
Open()is invoked, this timeout value is often insufficient for theFirmwareInstallmethod to complete successfully, and so theFirmwareInstallmethod overrides this timeout value and restores it when done.Checklist
Description for changelog/release notes