Add metadata field for error messages: #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 45.13% 45.31% +0.18%
==========================================
Files 40 40
Lines 3224 3235 +11
==========================================
+ Hits 1455 1466 +11
Misses 1605 1605
Partials 164 164
☔ View full report in Codecov by Sentry. |
2 tasks
jacobweinstock
force-pushed
the
add-metadata
branch
from
12fa10c
to
760d33c
Compare
joelrebel
requested changes
May 30, 2023
This adds the error message for failed method
calls per providers to metadata. These erorrs
were previously not accessible. These errors
are captured in metadata regardless of whether
the method returns successful or not. This is
helpful in debugging providers that error but
the method call succeeds.
The example metadata below shows that while the open method
call succeeded for ipmitool, dell, and gofish it did
not succeed for IntelAMT and asrockrack. We now have
access to the error messages for those failed one.
```
{
SuccessfulProvider:""
ProvidersAttempted:[ipmitool asrockrack gofish IntelAMT dell]
SuccessfulOpenConns:[ipmitool dell gofish]
SuccessfulCloseConns:[]
FailedConnDetail:
map[IntelAMT:provider: IntelAMT: unable to perform digest auth with http://192.168.2.205:16992/wsman: Post "http://192.168.2.205:16992/wsman": dial tcp 192.168.2.205:16992: connect: connection refused
asrockrack:provider: asrockrack: error unmarshalling response payload: invalid character '<' looking for beginning of value
]
}
```
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
jacobweinstock
force-pushed
the
add-metadata
branch
from
760d33c
to
1b631ee
Compare
FailedProviderDetail helps indicate that this metadata field is not for any specific method. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
joelrebel
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
This adds the error message for failed method calls per providers to metadata. These erorrs were previously not accessible. These errors are captured in metadata regardless of whether the method returns successful or not. This is helpful in debugging providers that error but the method call succeeds. This doesn't change the behavior of any methods. After each method call metadata can be interrogated for error messages of any failed providers.
The example metadata below shows that while the open method call succeeded for ipmitool, dell, and gofish it did not succeed for IntelAMT and asrockrack. We now have access to the error messages for those failed one.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes