-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per provider config: #326
Add per provider config: #326
Commits on May 8, 2023
-
There exists some config that cannot be shared across all providers. For example, the port for ipmitool is generally 623, but is generally 16992 for intelAMT. Allowing per provider config enables customizing this type of data. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 8ebc70c - Browse repository at this point
Copy the full SHA 8ebc70cView commit details -
Refactor to use provider specific config structs:
This allows the provider to specify all config it needs. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 6bb0b1d - Browse repository at this point
Copy the full SHA 6bb0b1dView commit details -
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f9f861f - Browse repository at this point
Copy the full SHA f9f861fView commit details -
Move all option related code to option.go
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a6d27a5 - Browse repository at this point
Copy the full SHA a6d27a5View commit details -
Remove error return from default http.Client constructor:
This makes New functions cleaner. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 02f085e - Browse repository at this point
Copy the full SHA 02f085eView commit details -
Add functional arguments for optional Ipmi struct values. Add additional struct values. Make cipher suite 3 the first suite tried. 3 is more commonly used then 17 so most machines will not try with 17 first. Add debug logging of ipmitool command line options. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e1aff89 - Browse repository at this point
Copy the full SHA e1aff89View commit details -
Update default http.Client constructor:
The new function signature does not return an error. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fe4dfaa - Browse repository at this point
Copy the full SHA fe4dfaaView commit details -
Add functional arguments and options:
This uniforms providers to using func args. Updates the client to work with this. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for fbec04f - Browse repository at this point
Copy the full SHA fbec04fView commit details -
Fix basic auth test and example. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for cfa88bf - Browse repository at this point
Copy the full SHA cfa88bfView commit details -
The registering of ipmitool provider doesnt ignore the error when its constructor is called. This means that systems without ipmitool will see that the ipmitool provider does not get registered. Previously it would always be registered. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 54a32d9 - Browse repository at this point
Copy the full SHA 54a32d9View commit details -
Allow for a 10 millisecond error of margin. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 47f65c1 - Browse repository at this point
Copy the full SHA 47f65c1View commit details -
Make gofish port customizable:
Previously it was not. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for f0e83f8 - Browse repository at this point
Copy the full SHA f0e83f8View commit details -
Use gofish opts for port instead of a func parameter:
This makes it more flexible and follows the pattern the other providers are using. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b52ee97 - Browse repository at this point
Copy the full SHA b52ee97View commit details -
Make asrockrack port configurable.
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for a22508e - Browse repository at this point
Copy the full SHA a22508eView commit details -
Add missing function back after main merge.
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 7dd578a - Browse repository at this point
Copy the full SHA 7dd578aView commit details -
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d91f2e7 - Browse repository at this point
Copy the full SHA d91f2e7View commit details
Commits on May 10, 2023
-
Rename gofish options to redfish:
gofish is an implementation detail that shouldnt be exposed like this. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 054fde6 - Browse repository at this point
Copy the full SHA 054fde6View commit details -
Remove debug print line, run go fmt:
Clean up. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for d1528bf - Browse repository at this point
Copy the full SHA d1528bfView commit details -
Clone the http.Client transport for each provider:
Extra precaution for race conditions. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 532dade - Browse repository at this point
Copy the full SHA 532dadeView commit details -
Update README to reflect function signature change
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9e2d7b3 - Browse repository at this point
Copy the full SHA 9e2d7b3View commit details -
`-race` flag was added to `make test` and requires CGO. go: -race requires cgo; enable cgo by setting CGO_ENABLED=1 Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 46acd6e - Browse repository at this point
Copy the full SHA 46acd6eView commit details