Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intel AMT library: #312

Merged
merged 4 commits into from
Mar 9, 2023
Merged

Conversation

jacobweinstock
Copy link
Member

The previous Intel AMT libraries were forks and the hope was that I would be able to upstream the changes. The upstreams themselves were actually forks and the PRs I opened have been sitting for some time. Because of all of this, I have created a new repo that I'll be maintaining. The new repo handles context timeouts across the board.

What does this PR implement/change/remove?

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

The previous Intel AMT libraries were forks and
the hope was that I would be able to upstream the
changes. The upstreams themselves were actually forks
and the PRs I opened have been sitting for some time.
Because of all of this, I have created a new repo that
I'll be maintaining. The new repo handles context timeouts
across the board.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.41 🎉

Comparison is base (bb58254) 43.11% compared to head (b46b875) 43.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   43.11%   43.52%   +0.41%     
==========================================
  Files          35       35              
  Lines        2723     2711      -12     
==========================================
+ Hits         1174     1180       +6     
+ Misses       1428     1410      -18     
  Partials      121      121              
Impacted Files Coverage Δ
providers/intelamt/intelamt.go 100.00% <100.00%> (+26.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here! apart from the debug print, it looks good to me.

providers/intelamt/intelamt.go Outdated Show resolved Hide resolved
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@mergify mergify bot merged commit 4d46ab2 into bmc-toolbox:main Mar 9, 2023
@jacobweinstock jacobweinstock deleted the amt-update branch March 9, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants