-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support redfish VirtualMedia #307
Conversation
Codecov ReportBase: 42.93% // Head: 42.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 42.93% 42.85% -0.08%
==========================================
Files 31 33 +2
Lines 2513 2597 +84
==========================================
+ Hits 1079 1113 +34
- Misses 1318 1367 +49
- Partials 116 117 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for work and contribution here, I've left a few suggestions.
aa00636
to
91e946c
Compare
Signed-off-by: Jonathan Behrens <jbehrens@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes!
What does this PR implement/change/remove?
This PR adds support for setting redfish virtual media. It can be used, for instance, to specify the URL of an ISO image that the machine should boot from.
Checklist
The HW vendor this change applies to (if applicable)
Redfish. Tested on a Dell R640 server.
Description for changelog/release notes