Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redfish VirtualMedia #307

Merged
merged 2 commits into from
Feb 12, 2023
Merged

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia commented Jan 31, 2023

What does this PR implement/change/remove?

This PR adds support for setting redfish virtual media. It can be used, for instance, to specify the URL of an ISO image that the machine should boot from.

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

Redfish. Tested on a Dell R640 server.

Description for changelog/release notes

Added Redfish VirtualMedia support

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 42.93% // Head: 42.85% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (24626d4) compared to base (2a1f02f).
Patch coverage: 40.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   42.93%   42.85%   -0.08%     
==========================================
  Files          31       33       +2     
  Lines        2513     2597      +84     
==========================================
+ Hits         1079     1113      +34     
- Misses       1318     1367      +49     
- Partials      116      117       +1     
Impacted Files Coverage Δ
client.go 24.79% <0.00%> (-0.85%) ⬇️
internal/redfishwrapper/virtual_media.go 0.00% <0.00%> (ø)
providers/redfish/redfish.go 17.18% <0.00%> (-0.56%) ⬇️
bmc/virtual_media.go 94.44% <94.44%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for work and contribution here, I've left a few suggestions.

internal/redfishwrapper/virtual_media.go Show resolved Hide resolved
internal/redfishwrapper/virtual_media.go Outdated Show resolved Hide resolved
internal/redfishwrapper/virtual_media.go Outdated Show resolved Hide resolved
bmc/virtual_media.go Outdated Show resolved Hide resolved
bmc/virtual_media.go Show resolved Hide resolved
client.go Outdated Show resolved Hide resolved
Signed-off-by: Jonathan Behrens <jbehrens@microsoft.com>
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@joelrebel joelrebel merged commit bac6449 into bmc-toolbox:main Feb 12, 2023
@fintelia fintelia deleted the virtual-media branch February 12, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants