providers/AsRockRack: fixes user update on ROMED8HM3 Megarac #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few new fields are now required, tested on these devices running the Megarac BMC firmware, - EPYC3101D4I-NL - ROMED8HM3
Codecov ReportBase: 45.45% // Head: 45.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #306 +/- ##
==========================================
+ Coverage 45.45% 45.53% +0.07%
==========================================
Files 27 27
Lines 2268 2271 +3
==========================================
+ Hits 1031 1034 +3
Misses 1122 1122
Partials 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
diogomatsubara
approved these changes
Jan 30, 2023
splaspood
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Updates the AsRockRack provider to work with Megarac BMC firmware running on ROMED8HM3
A few new fields are now required, tested on these devices running the Megarac BMC firmware,
Tested on,
Checklist
The HW vendor this change applies to (if applicable)
AsRockRack
The HW model number, product name this change applies to (if applicable)
ROMED8HM3
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes