Rework intel amt provider to not panic: #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Panics were happening because of not handling return errors from `amt.NewClient`. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Codecov ReportBase: 46.41% // Head: 45.49% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #304 +/- ##
==========================================
- Coverage 46.41% 45.49% -0.92%
==========================================
Files 27 27
Lines 2273 2266 -7
==========================================
- Hits 1055 1031 -24
- Misses 1103 1120 +17
Partials 115 115
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
Panics were happening because of not handling return errors from
amt.NewClient.Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
Intel AMT
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes
Fix IntelAMT provider panics.