Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use renamed module for go-amt #297

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

jacobweinstock
Copy link
Member

What does this PR implement/change/remove?

The Go module of my fork of github.com/ammmze/wsman has been updated to github.com/jacobweinstock/wsman
This will allow imports of this to not have to specify replace directives in go.mod. The hope is that the upstream will accept the context changes and this won't be necessary.

Fixes #295

Checklist

  • Tests added
  • Similar commits squashed

The HW vendor this change applies to (if applicable)

The HW model number, product name this change applies to (if applicable)

The BMC firmware and/or BIOS versions that this change applies to (if applicable)

What version of tooling - vendor specific or opensource does this change depend on (if applicable)

Description for changelog/release notes

This will allow imports of this to not have
to specify replace directives in go.mod. The
hope is that the upstream will accept the context
changes and this wont be necessary.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Base: 43.69% // Head: 43.69% // No change to project coverage 👍

Coverage data is based on head (b5f2a72) compared to base (4400298).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   43.69%   43.69%           
=======================================
  Files          27       27           
  Lines        2435     2435           
=======================================
  Hits         1064     1064           
  Misses       1248     1248           
  Partials      123      123           
Impacted Files Coverage Δ
providers/intelamt/intelamt.go 98.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

joelrebel
joelrebel previously approved these changes Nov 25, 2022
Main was recently created from the v2 branch, but this
config was not updated to match.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Copy link
Member

@joelrebel joelrebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing mergify as well!

@jacobweinstock jacobweinstock merged commit 9694653 into bmc-toolbox:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build failure on intelAMT provider
2 participants