Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redfish/dell tasks: register task names for NIC, Drive, controllers #282

Merged
merged 1 commit into from
Jul 28, 2022
Merged

redfish/dell tasks: register task names for NIC, Drive, controllers #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions providers/redfish/tasks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,11 @@ import (

var (
componentSlugDellJobName = map[string]string{
common.SlugBIOS: "Firmware Update: BIOS",
common.SlugBMC: "Firmware Update: iDRAC with Lifecycle Controller",
common.SlugBIOS: "Firmware Update: BIOS",
common.SlugBMC: "Firmware Update: iDRAC with Lifecycle Controller",
common.SlugNIC: "Firmware Update: Network",
common.SlugDrive: "Firmware Update: Serial ATA",
common.SlugStorageController: "Firmware Update: SAS RAID",
}
)

Expand Down Expand Up @@ -57,7 +60,6 @@ func (c *Conn) getDellFirmwareInstallTaskScheduled(slug string) (*rf.Task, error

// filter to match the task Name based on the component slug
for _, task := range tasks {
// Firmware Update: BIOS
if task.Name == componentSlugDellJobName[strings.ToUpper(slug)] {
return task, nil
}
Expand All @@ -75,7 +77,6 @@ func (c *Conn) dellPurgeScheduledFirmwareInstallJob(slug string) error {

// filter to match the task Name based on the component slug
for _, task := range tasks {
// Firmware Update: BIOS
if task.Name == componentSlugDellJobName[strings.ToUpper(slug)] {
err = c.dellPurgeJob(task.ID)
if err != nil {
Expand Down