Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(EvmBuilder): Remove unnecessary BuilderStage trait #979

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 15, 2024

The trait is not needed, so we can remove it.

Copy link
Contributor

Valgrind Results:

==4010== Cachegrind, a cache and branch-prediction profiler
==4010== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==4010== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==4010== Command: target/release/snailtracer
==4010== 
--4010-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==4010== 
==4010== I   refs:      455,348,071
==4010== I1  misses:          4,567
==4010== LLi misses:          2,889
==4010== I1  miss rate:        0.00%
==4010== LLi miss rate:        0.00%
==4010== 
==4010== D   refs:      237,388,463  (160,564,998 rd   + 76,823,465 wr)
==4010== D1  misses:        349,240  (    208,935 rd   +    140,305 wr)
==4010== LLd misses:        137,562  (      4,049 rd   +    133,513 wr)
==4010== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==4010== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==4010== 
==4010== LL refs:           353,807  (    213,502 rd   +    140,305 wr)
==4010== LL misses:         140,451  (      6,938 rd   +    133,513 wr)
==4010== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 6a8b44d into main Jan 15, 2024
23 checks passed
@github-actions github-actions bot mentioned this pull request Jan 15, 2024
@rakita rakita deleted the rm_builder_stage_trait branch January 19, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant