Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op): skip validation on deposit tx #1065

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix(op): skip validation on deposit tx #1065

merged 2 commits into from
Feb 8, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Feb 8, 2024

closes: #1063

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Valgrind Results:

==3993== Cachegrind, a cache and branch-prediction profiler
==3993== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3993== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3993== Command: target/release/snailtracer
==3993== 
--3993-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==3993== 
==3993== I   refs:      463,562,032
==3993== I1  misses:          3,450
==3993== LLi misses:          2,896
==3993== I1  miss rate:        0.00%
==3993== LLi miss rate:        0.00%
==3993== 
==3993== D   refs:      237,388,457  (160,564,993 rd   + 76,823,464 wr)
==3993== D1  misses:        323,557  (    183,726 rd   +    139,831 wr)
==3993== LLd misses:        137,539  (      4,061 rd   +    133,478 wr)
==3993== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==3993== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3993== 
==3993== LL refs:           327,007  (    187,176 rd   +    139,831 wr)
==3993== LL misses:         140,435  (      6,957 rd   +    133,478 wr)
==3993== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit 0654850 into main Feb 8, 2024
24 of 25 checks passed
@DaniPopes DaniPopes deleted the op_fix_skip_validation branch March 13, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not verify balance for Optimism deposit transactions
1 participant