Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Inspector): Add return_memory_offset to Inspector::call #1006

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

rakita
Copy link
Member

@rakita rakita commented Jan 23, 2024

closes: #1001

Copy link
Contributor

Valgrind Results:

==3732== Cachegrind, a cache and branch-prediction profiler
==3732== Copyright (C) 2002-2017, and GNU GPL'd, by Nicholas Nethercote et al.
==3732== Using Valgrind-3.18.1 and LibVEX; rerun with -h for copyright info
==3732== Command: target/release/snailtracer
==3732== 
--3732-- warning: L3 cache found, using its data for the LL simulation.
Snailtracer Host+Interpreter benchmark (2.1s) ...            not enough samples
==3732== 
==3732== I   refs:      455,350,091
==3732== I1  misses:         16,872
==3732== LLi misses:          2,876
==3732== I1  miss rate:        0.00%
==3732== LLi miss rate:        0.00%
==3732== 
==3732== D   refs:      237,389,150  (160,565,454 rd   + 76,823,696 wr)
==3732== D1  misses:        348,820  (    208,520 rd   +    140,300 wr)
==3732== LLd misses:        137,560  (      4,050 rd   +    133,510 wr)
==3732== D1  miss rate:         0.1% (        0.1%     +        0.2%  )
==3732== LLd miss rate:         0.1% (        0.0%     +        0.2%  )
==3732== 
==3732== LL refs:           365,692  (    225,392 rd   +    140,300 wr)
==3732== LL misses:         140,436  (      6,926 rd   +    133,510 wr)
==3732== LL miss rate:          0.0% (        0.0%     +        0.2%  )

@rakita rakita merged commit dc2a0fc into main Jan 23, 2024
25 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
@rakita rakita deleted the return_mem_offset branch January 23, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CallOutcome memory_offset is confusing/hard to use
1 participant