-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(default-flatpaks): version 2 (nushell) #336
base: main
Are you sure you want to change the base?
Conversation
this version just sets up the config file but nothing to read it and install the flatpaks after boot
Regarding code structure, it looks cleaner, simpler & I generally like it. Only thing which clutters things very much is Is JSON as a config format necessarry? I find Also printing the message for every checked FlatHub flatpak ID is too much imo, it should only print success message once & print error when ID is wrong. Recipe format looks good to me, except maybe instead of Thanks for starting this PR, I'll look into learning Nushell, so I can also contribute |
Nice!
Ok, maybe I went a bit overboard with that. I'll fix that in the next commits. Sure
Do we? I haven't seen that.
It's not a config format for humans, it won't be writeable as it will exist only in the
Those "modifications" can't actually modify each other, though... I chose "installations", because it IMO reflects that each entry means one set of Flatpaks installed from a specific repo to a specific scope. I guess it feels redundant with the |
It's easier to read for users who want to know what's modified in the image, hence the reason I insist on it.
|
I don't really like that either, because it's two-parted and does not feel like it makes sense for a list of separate configurations. Maybe |
Looks good to me |
This PR is a draft of the rewrite of
default-flatpaks
to support multiple repositories, pioneer Nushell-based modules, and rethink the config structure.Current version implements only the build-time part. Plan is to write to
/usr/share/bluebuild/default-flatpaks/configuration.json
at build time and read from there in the post-boot parts.The recipe format is still up for debate. I didn't end up using anything in #146 for now. The current approach is basically the same as my original suggestion, except that one module call can install Flatpaks in multiple scopes from multiple repositories. The terminology still feels off. Feel free to suggest improvements.
Also feel free to look at the source code to see if you mostly understand it and if it is more readable than the v1 source.
The syntax highlighting on GitHub might be a bit weird, though, because I had to make the file end in
.sh
due to our current system hardcoding that in. I'm not sure what we could do about that, maybe make it possible to omit the file extension entirely.Testing
recipe:
example output: