Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iso): Create generate-iso command #192

Merged

Conversation

gmpinder
Copy link
Member

@gmpinder gmpinder commented Jun 9, 2024

Tasks

  • Add ctrl-c handler to kill spawned children
  • add more args to support all variables
  • Add integration test

@gmpinder gmpinder added the type: feature Brand new functionality, features, pages, workflows, endpoints, etc. label Jun 9, 2024
@gmpinder gmpinder self-assigned this Jun 9, 2024
@gmpinder gmpinder linked an issue Jun 9, 2024 that may be closed by this pull request
@fiftydinar
Copy link
Contributor

Can't see from the commits, does this uses this action?

https://github.com/JasonN3/build-container-installer

Bundling flatpaks inside the ISO from the default-flatpaks module recipe would be also great.

However, I find that it doesn't work properly in my testing for some reason (flatpaks installed, but they miss refs, hence they failed to update).
However, I use custom named flathub-system remote instead of flathub so maybe that's what contributed to it.

@gmpinder
Copy link
Member Author

gmpinder commented Jun 9, 2024

Can't see from the commits, does this uses this action?

https://github.com/JasonN3/build-container-installer

Bundling flatpaks inside the ISO from the default-flatpaks module recipe would be also great.

However, I find that it doesn't work properly in my testing for some reason (flatpaks installed, but they miss refs, hence they failed to update).
However, I use custom named flathub-system remote instead of flathub so maybe that's what contributed to it.

I'm still working on the implementation, but yes I'll be using the image from that action to build the ISO. I've got a lot of testing to do and I'd appreciate y'all testing it out too when I get it into a decent state

@gmpinder gmpinder added this to the v0.9.0 milestone Jun 23, 2024
@fiftydinar
Copy link
Contributor

fiftydinar commented Jul 6, 2024

It seems that latest Fedora 40 images require bootupd to be installed & bootupctl backend generate-update-metadata command to be done inside the image. Fedora 39 images don't support this operation (but also don't have this issue).
The command updates the bootloader metadata which would be further used by bootc in installer to update the bootloader data inside the system to latest version. That's how I understand it.

Maybe old Anaconda versions prior to latest 1.2.1 install the older bootloader version, which is not compatible with the kernel. 1.2.1 adds the support for using bootc to circumvent this issue. This is just a speculation, I'm not sure.

I made the issue in upstream ISO generator repo:
JasonN3/build-container-installer#127

@gmpinder gmpinder marked this pull request as ready for review September 2, 2024 05:55
@gmpinder gmpinder changed the title feat(experimental): Create generate-iso command feat(iso): Create generate-iso command Sep 2, 2024
@gmpinder gmpinder force-pushed the 151-feat-add-generate-iso-command-for-local-creation-of-isos branch from 9cf9c52 to bed0c32 Compare September 4, 2024 17:56
@gmpinder gmpinder merged commit e6cce3d into main Sep 4, 2024
12 checks passed
@gmpinder gmpinder deleted the 151-feat-add-generate-iso-command-for-local-creation-of-isos branch September 4, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add generate ISO command for local creation of ISOs
2 participants