Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make Ransack distinct optional #33

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blocknotes
Copy link
Owner

@blocknotes blocknotes commented Jul 7, 2024

Relates to #28

@blocknotes blocknotes self-assigned this Jul 7, 2024
@goosys
Copy link
Contributor

goosys commented Jul 30, 2024

@blocknotes I believe ransack_result_distinct should be a private or protected method, so it should work correctly even when it is a private method. The same applies to ransack_options, which was added previously. What do you think?

  def scoped_resource
    options = respond_to?(:ransack_options, true) ? ransack_options : {}
    distinct = respond_to?(:ransack_result_distinct, true) ? ransack_result_distinct : true
    ...
  end

  private def ransack_options; end
  private def ransack_result_distinct; end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants