[legacy-framework] style: fix editor integration with ESLint #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thank you so much! |
dillondotzip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: tooling fix
Closes: blitz-js/legacy-framework#492
What are the changes and their implications? ⚙️
Ran
tsdx lint --write-fileto "eject" the tsdx ESLint config and merged in our recent adoption of theunicornplugin and corresponding rules.Checklist
packages/server/src/log.tsBreaking change: no
N/A
Other information
The tsdx CLI supports merging
.eslintrc.js(don't think it honors.eslintrcthough), but that isn't enough for VSCode, which doesn't know to perform said merge (so it only looks at the config it finds, which in this case is missing things like the TS parser, etc.). The solution from tsdx is to "eject" the ESLint config if you need to extend it while retaining editor integration.