Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set User Agent for FFmpeg calls #4555

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

felipecrs
Copy link
Contributor

Closes #4369

@netlify
Copy link

netlify bot commented Nov 30, 2022

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 1799a4f
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6387b5800f49fe0009e35bca

@felipecrs
Copy link
Contributor Author

Another option I thought of was to set them here, disallowing users to override:

image

.vscode/launch.json Show resolved Hide resolved
@NickM-27
Copy link
Sponsor Collaborator

Another option I thought of was to set them here, disallowing users to override:

image

I see no reason to make it mandatory, users should be able to change it if they want to

@felipecrs
Copy link
Contributor Author

I see no reason to make it mandatory, users should be able to change it if they want to

Cool, I agree.

@NickM-27 NickM-27 self-requested a review November 30, 2022 15:40
.gitignore Outdated Show resolved Hide resolved
@blakeblackshear blakeblackshear merged commit 4523c9b into blakeblackshear:dev Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set -user_agent in ffmpeg calls
3 participants