Remove wheels from final container #4395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
The CI failure has nothing to do with my change. |
run |
felipecrs
force-pushed
the
remove-wheels
branch
from
0c670f4
to
baac2eb
Compare
blakeblackshear
approved these changes
Nov 16, 2022
herostrat
pushed a commit
to herostrat/frigate
that referenced
this pull request
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this simple change we reduce the image size from 1.52GB to 1.36GB.
It turns out that, when you
COPY /wheels, you create a layer with it. You can remove it after, but the layer will remain there adding up to the image size. That's how docker works.