-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option enabled for each camera in config #4162
Merged
blakeblackshear
merged 9 commits into
blakeblackshear:dev
from
banthungprong:disable-camera-in-config
Nov 2, 2022
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1fe6236
add option enabled for each camera in config
banthungprong 52ac65a
Simplified If-block and removed wrong Optional
banthungprong 9d86f94
Update Docs enabling/disabling camera in config
banthungprong 4c78b49
correct format for option
banthungprong 79548ff
Disabling Camera for processes, no config changes
banthungprong ffbfc9f
Describe effects of disabled cam in documentation
banthungprong cb88ff1
change if-logic, obsolete copy, info disabled cam
banthungprong d05266f
changed color to white, added top padding in disabled camera info
banthungprong 2fa0316
changed indentation
banthungprong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
@@ -380,6 +380,10 @@ timestamp_style: | |||||||||||||
cameras: | ||||||||||||||
# Required: name of the camera | ||||||||||||||
back: | ||||||||||||||
# Optional: Enable/Disable the camera (default: shown below). | ||||||||||||||
# If disabled: config is used but no live stream and no capture etc. | ||||||||||||||
# Events/Recordings are still viewable. | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
this is what I mean, the start of the comment is indented too much There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this still needs to be addressed |
||||||||||||||
enabled: True | ||||||||||||||
# Required: ffmpeg settings for the camera | ||||||||||||||
ffmpeg: | ||||||||||||||
# Required: A list of input streams for the camera. See documentation for more information. | ||||||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation is incorrect for these (# is correct but doesn't need space after)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand this. Formatting is the same like other comment blocks with the Optional.
# in the same columns like the next line "enabled : True
and after # the same blanks like a few lines above