Add GPU stats to the /stats API and debug screen #3931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added intel_gpu_top for now, need to verify if it can work in the container: |
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
force-pushed
the
gpu-stats
branch
4 times, most recently
from
85baa38
to
f140dfd
Compare
|
Here's an example of what will happen if there is an error getting gpu stats
|
NickM-27
force-pushed
the
gpu-stats
branch
2 times, most recently
from
0425a36
to
3ed0409
Compare
| """Get stats for cpu / gpu.""" | ||
|
|
||
| async def run_tasks() -> None: | ||
| await asyncio.wait( |
There was a problem hiding this comment.
Is the only reason to introduce asyncio stuff here so we can wait for these to run in parallel?
There was a problem hiding this comment.
Yes, with the cpu and 2 gpus my production server takes ~ 7-10 seconds and with this it's more like 3-5 seconds. There definitely may be better ways to parallelize it or run the actual checks in the background and cache / average the returned results so when /stats is called it can return without waiting.
NickM-27
force-pushed
the
gpu-stats
branch
2 times, most recently
from
4b3e124
to
fa7a362
Compare
blakeblackshear
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to view current GPU utilization and GPU memory utilization from hwaccel args.
Unfortunately each GPU API has a different set of features so there will be some difference (for example nvidia-smi can return the model GPU).
To - Do:
intel_gpu_top