Linux Support #21
Merged
Linux Support #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added some small changes to allow Linux-based systems to use the extension since I'm currently working on a project in both Windows and Linux and in Linux the user cannot fully enjoy what the extension offers.
I touched these features:
To allow test play, the user must install Wine on their system, if it is not installed it will just report back to the logging service that executing the test play is not possible in case the user does not want to install Wine and just use the extension to modify scripts.
I've been testing and it's working nicely on my end. I modified the README to reflect the changes.
EDIT: I also added the "category" for all commands in the
package.jsonto quickly access the commands from the command palette for testing, feel free to revert back the changes if desirable.