Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BSIP 33: Maker Orders With Better Prices Take Precedence #57

Merged
merged 7 commits into from
Feb 22, 2018
Merged

Add BSIP 33: Maker Orders With Better Prices Take Precedence #57

merged 7 commits into from
Feb 22, 2018

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Feb 17, 2018 •
edited
Loading

@pmconrad
Copy link
Contributor

Hm, IMO there's a big overlap between this and BSIP-32, perhaps merge them into one?

@abitmore
Copy link
Member Author

IMO they're two things, so I prefer two BSIP's.

By the way I'll reorganize this as well.

@xeroc
Copy link
Member

xeroc commented Feb 19, 2018

Can you maybe clarify to the reader what the difference to #56 (bsip32) is?

@abitmore
Copy link
Member Author

@xeroc The title explains.

@xeroc xeroc merged commit e12c618 into master Feb 22, 2018
@abitmore abitmore deleted the bsip33 branch February 26, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeroc xeroc xeroc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abitmore @pmconrad @xeroc